master gremlin: Initialize preview interpreter with active modal gcodes#4123
Open
Sigma1912 wants to merge 1 commit into
Open
master gremlin: Initialize preview interpreter with active modal gcodes#4123Sigma1912 wants to merge 1 commit into
Sigma1912 wants to merge 1 commit into
Conversation
Sigma1912
changed the title
Sigma1912
force-pushed
the
gremlin_fix_initializing_preview_interp
branch
from
7dda1b6 to
93bf5ad
Compare
grandixximo
suggested changes
Jun 4, 2026
Improve preview for gcode with incomplete preambles
Sigma1912
force-pushed
the
gremlin_fix_initializing_preview_interp
branch
from
93bf5ad to
bd031ae
Compare
Contributor
|
code = "G%d" % (i//10) if i%10==0 else "G%d.%d" % (i//10, i%10)Suggest same split, and a test that |
Collaborator
|
As qr_graphics uses very similar cide, can you add to or create a pull request for it too? I'm away working and dont want to get them out of step. |
Contributor
Author
It's an easy enough change but having a trailing
I'll have a look at adding a test. Do you have any pointers on how I might test the preview? @c-morley |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4121 and improves preview for gcode with incomplete preambles.
No regression on #2753
No regression on #3855
Affects gmoccapy and any other gui using gremlin.